Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): Fix convert missing key in .zapierapprc file #640

Merged
merged 1 commit into from
Apr 6, 2023
Merged

fix(cli): Fix convert missing key in .zapierapprc file #640

merged 1 commit into from
Apr 6, 2023

Conversation

FokkeZB
Copy link
Contributor

@FokkeZB FokkeZB commented Apr 6, 2023

When you run zapier convert, the .zapierapprc file that it generates is missing the key property.

This PR fixes that, and includes a test to prevent regressions.

eliangcs
eliangcs approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eliangcs eliangcs merged commit 0adb5c0 into zapier:main Apr 6, 2023
@FokkeZB FokkeZB deleted the STAFF-247 branch April 6, 2023 12:51
@rnegron rnegron mentioned this pull request May 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliangcs eliangcs eliangcs approved these changes

@rnegron rnegron Awaiting requested review from rnegron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FokkeZB @eliangcs