PDE-3006 fix(legacy-scripting-runner): fix issues with file uploading #496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two bugs with file uploading.
The
Content-Typeheader should be set tomultipart/form-datawhen uploading a file. We were using form-data to generate the request body, but we should also useform.getHeaders()to generate a header likeContent-Type: multipart/form-data; boundary=----12345678.Hanging issue. We were using the request package for 1)
z.requestin the legacy script and 2) downloading files. I found when there's a syncz.requestcall in the legacy script, therequestcall to download a file can hang the entire process. I'm not sure why but I guess it's related to deasync. This PR fixes the issue by replacingrequestwithnode-fetchto download files.