Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): Add code type for inputFields #439

Merged
merged 2 commits into from
Oct 28, 2021
Merged

feat(core): Add code type for inputFields #439

merged 2 commits into from
Oct 28, 2021

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Oct 27, 2021

Adds an already-recognized inputField type as a valid option

PDE-2856

@xavdid xavdid requested a review from eliangcs as a code owner October 27, 2021 19:58
Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xavdid I didn't know we support code as a field type. Can you provide more context on this change? Are there any production apps that are using it?

@xavdid
Copy link
Contributor Author

xavdid commented Oct 28, 2021

Yes! sorry, there's a slack thread and monolith line linked in the jira ticket.

This a field type recognized by the editor already, it's just not in schema.

Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks for the context!

@xavdid xavdid merged commit 208e0a6 into master Oct 28, 2021
@xavdid xavdid deleted the PDE-2856 branch October 28, 2021 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants