PDE-2584 fix(legacy-scripting-runner): default to auth fields if auth mapping is empty #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mapping is empty
eliangcs
commented
Oct 27, 2021
Comment on lines
+30
to
+32
| if (_.isEmpty(authMapping)) { | ||
| return authData; | ||
| } |
There was a problem hiding this comment.
This is the key of this change.
xavdid
approved these changes
Oct 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scenario to reproduce the issue
legacy.authentication.mappingis{}){"api_key": "secret"}querystringExpected behavior
The request query params should have
api_key:{ "url": "https://example.com", "params": {"api_key": "secret"} }Current behavior
The request query params have no
api_key:{ "url": "https://example.com" }