Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUPPORTESC-163 docs(cli): Update historical releases section to include v10 #377

Merged
merged 3 commits into from
May 21, 2021

Conversation

nicolemichellethomas
Copy link
Contributor

@nicolemichellethomas nicolemichellethomas commented May 20, 2021

Starting Draft pull request to update docs with links to v10.2.0, now that they are on v11

@nicolemichellethomas nicolemichellethomas changed the title docs(cli): Update historical releases section to include v10 SUPPORTESC-163 docs(cli): Update historical releases section to include v10 May 20, 2021
@nicolemichellethomas nicolemichellethomas marked this pull request as ready for review May 20, 2021 19:12
@xavdid
Copy link
Contributor

xavdid commented May 20, 2021

Thanks for this contribution @nicolemichellethomas. The only trick is that you'll need to make changes in the README-source.md file instead of README. Then, when you commit (if you're run yarn recently), the new docs will auto-build.

Let me know if that doesn't make sense!

Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit that makes the change on README-source.md and regenerates the docs. Thanks!

@eliangcs eliangcs merged commit 55a3908 into master May 21, 2021
@eliangcs eliangcs deleted the SUPPORTESC-163-add-links-to-v10.2.0 branch May 21, 2021 02:50
@szchenghuang szchenghuang restored the SUPPORTESC-163-add-links-to-v10.2.0 branch May 21, 2021 08:55
@szchenghuang szchenghuang deleted the SUPPORTESC-163-add-links-to-v10.2.0 branch May 21, 2021 08:55
@nicolemichellethomas
Copy link
Contributor Author

Oh sorry folks! Thanks for the information, and the assist!

@xavdid
Copy link
Contributor

xavdid commented May 21, 2021

No problem at all! It's a confusing setup. I figured you'd continue to make readme updates, so now you know! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants