Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): ensure test files can be run out of the box with jest #327

Merged
merged 2 commits into from
Feb 18, 2021
Merged

fix(cli): ensure test files can be run out of the box with jest #327

merged 2 commits into from
Feb 18, 2021

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Feb 12, 2021

Test files were still using a mocha setup instead of jest. Now newly-scaffolded tests will run correctly.

PDE-1907

@xavdid xavdid requested a review from eliangcs as a code owner February 12, 2021 21:29
eliangcs
eliangcs previously approved these changes Feb 15, 2021
View reviewed changes
Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I didn't test as I assume you've tested.

@xavdid
Copy link
Contributor Author

xavdid commented Feb 17, 2021

sure did! fixed the failing smoke test (updated file name) too.

@xavdid xavdid merged commit c4a6dc8 into master Feb 18, 2021
@xavdid xavdid deleted the PDE-1907 branch February 18, 2021 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliangcs eliangcs eliangcs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xavdid @eliangcs