PDE-1982: fix(core): ResponseError shouldn't assume response.content is always present #320
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
z.request({raw: true})
, usually used for file dehydration, is failing to raise a properResponseError
when it gets an error response. This is because theResponseError
class assumesresponse.content
is always available, which is not true. In theprepareResponse
middleware, we makereponse.content
throw an error.The fix is to be more defensive in
ResponseError
. Whenresponse.content
throws an error, we simply keepResponseError.content
null.fixes #315