Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Add callback_url fallback for testing #280

Merged
merged 2 commits into from
Oct 14, 2020

Conversation

codebycaleb
Copy link
Contributor

z.generateCallbackUrl() presently returns undefined when called via AppTester. This commit adds a placeholder value to be returned by z.generateCallbackUrl() - 'auth-json-server.zapier-staging.com/echo'.

z.generateCallbackUrl() will return undefined when called via
AppTester. This commit adds a placeholder value to be returned by
z.generateCallbackUrl() - auth-json-server.zapier-staging.com/echo.
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh nice! great catch.

@xavdid xavdid changed the title feat(cli): Add callback_url fallback for testing fix(core): Add callback_url fallback for testing Oct 14, 2020
@codebycaleb codebycaleb merged commit 79cec9d into master Oct 14, 2020
@codebycaleb codebycaleb deleted the add-callback-fallback branch October 14, 2020 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants