Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core) add types for z.dehydrateFile and improve overloads for z.stashFile #240

Merged
merged 1 commit into from
Jun 10, 2020
Merged

fix(core) add types for z.dehydrateFile and improve overloads for z.stashFile #240

merged 1 commit into from
Jun 10, 2020

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Jun 9, 2020

closes #239 closes #238

@xavdid xavdid requested a review from eliangcs as a code owner June 9, 2020 17:09
eliangcs
eliangcs approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@xavdid xavdid merged commit bb4bfcb into master Jun 10, 2020
@xavdid xavdid deleted the ts-def-fixes-hydration branch June 10, 2020 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliangcs eliangcs eliangcs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The type definition of ZObject.stashFile() is invalid The type of dehydrateFile() is not defined in ZOjbect
2 participants
@xavdid @eliangcs