fix(legacy-scripting-runner): prune body if allowGetBody and body is empty #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliangcs
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #195, we introduced
allowGetBodyas az.requestoption. There's a bug. When the option is enabled, we always send an empty object as the request body. Depending on the server implementation, some could raise an error if they get a{}in a GET request's body. This PR fixes that so legacy-scripting-runner doesn't do that. Core will still do that (sends an empty-object request body), so we should fix it from core too. But given that legacy-scripting-runner is the only user ofallowGetBody, we can fix it later.