Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prefixes, move examples out of packages #2

Merged
merged 5 commits into from
Jun 12, 2019
Merged

Remove prefixes, move examples out of packages #2

merged 5 commits into from
Jun 12, 2019

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Jun 11, 2019 •
edited
Loading

Cleans up directory names and adapts yarn workspaces:

  • Remove the prefix zapier-platform- from all packages/zapier-platform-* directories
  • Move examples out of packages and rename it example-apps
  • Edit learn.json and package.json so Learn uses yarn workspaces

@eliangcs eliangcs marked this pull request as ready for review June 11, 2019 09:57
stevelikesmusic
stevelikesmusic approved these changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@stevelikesmusic stevelikesmusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good @eliangcs! I love the way this is coming together

@xavdid xavdid mentioned this pull request Jun 11, 2019
Merged
@eliangcs eliangcs merged commit 9e776f0 into master Jun 12, 2019
@eliangcs eliangcs deleted the big-move branch June 12, 2019 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevelikesmusic stevelikesmusic stevelikesmusic approved these changes

@xavdid xavdid Awaiting requested review from xavdid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliangcs @stevelikesmusic