Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): show variable name in curlies type error #188

Merged
merged 1 commit into from
Apr 1, 2020

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Mar 31, 2020

We've seen many developers getting confused by the error message Cannot reliable interpolate objects or arrays into a string. It can be hard to figure out which trigger or action is having an issue without knowing the variable being resolved.

This PR changes the error message from:

Cannot reliable interpolate objects or arrays into a string. We received an Array:
"1,2,3"

to

Cannot reliable interpolate objects or arrays into a string. Variable `bundle.inputData.foo` is an Array:
"1,2,3"

@eliangcs eliangcs requested a review from xavdid as a code owner March 31, 2020 06:02
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this is a good little improvement.

I was trying to see if we could pass in the trigger key as well to really point them there, but without changing the method signature, I'm not sure we can. Probably not worth it this second.

Copy link
Contributor

@stevelikesmusic stevelikesmusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a better message @eliangcs 👏 Looks good.

@eliangcs eliangcs merged commit 864229c into master Apr 1, 2020
@eliangcs eliangcs deleted the more-clear-curlies-type-error branch April 1, 2020 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants