Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cli) finish main oclif migration & remove unneeded code #133

Merged
merged 2 commits into from
Dec 19, 2019
Merged

chore(cli) finish main oclif migration & remove unneeded code #133

merged 2 commits into from
Dec 19, 2019

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Dec 19, 2019 •
edited
Loading

Now that all are commands are in oclif, there's a lot of no-longer-needed code we can pull.

It's a lot of lines, but actually pretty straightforward. Things of note:

  • moved everything that was still being handled in entry.js to init hooks
  • removed unused utils & related tests
  • added a plugin to replicate the did you mean functionality
  • cleaned up last few references to the full required utils

@xavdid xavdid marked this pull request as ready for review December 19, 2019 03:08
@xavdid xavdid requested a review from eliangcs as a code owner December 19, 2019 03:08
@xavdid xavdid changed the title chore(cli) remove unneeded code chore(cli) finish main oclif migration & remove unneeded code Dec 19, 2019
eliangcs
eliangcs approved these changes Dec 19, 2019
View reviewed changes
Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! We finally did it! 🎉

@xavdid xavdid merged commit 62003eb into master Dec 19, 2019
@xavdid xavdid deleted the migrate-to-oclif-fully branch December 19, 2019 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliangcs eliangcs eliangcs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xavdid @eliangcs