BREAKING CHANGE(cli): add user management commands, remove old ones #106
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok! This was a long one.
Refactors the
zapier invite
command into:users:add
users:remove
users:get
users:links
Refactors the
zapier collaborate
command into:team:add
team:remove
team:get
As is, the code is fairly repetitive. We're under a little bit of a deadline to get this out, so rather than spend too much time here drying it up, I wanted to get it out the door. In particular, we can probably clean up reused code between the
:add
commands and how we split api calls between subscribers and collaborators.For the review, pay particular attention to:
Also, it would be great to be able to call
this.exit()
without it looking like an error. The only way I could think to do that is to throw an error with a specific message that we handle at the top-level. I don't love using errors for control flow though. In any case, a simplereturn
from ourperform()
is perfectly serviceable.