Bump versions of dependencies and Node.js #94
Conversation
|
Until |
kola-er
changed the title
.travis.yml
Outdated
| @@ -2,7 +2,7 @@ language: node_js | |||
| node_js: | |||
| - 6.10.3 | |||
| - '7' | |||
There was a problem hiding this comment.
we can remove 7, it'll never be on AWS.
we could also add '10' just to see if there's anything bad (eventually) coming down the pipe
package.json
Outdated
| "node-fetch": "1.7.1", | ||
| "zapier-platform-schema": "6.1.0" | ||
| "node-fetch": "2.1.2", | ||
| "zapier-platform-schema": "7.0.0" |
There was a problem hiding this comment.
this gets bumped automatically on release, so we shouldn't change it manually here.
package.json
Outdated
| @@ -36,8 +36,8 @@ | |||
| "dotenv": "5.0.1", | |||
| "form-data": "2.2.0", | |||
| "lodash": "4.17.10", | |||
| "node-fetch": "1.7.1", | |||
| "zapier-platform-schema": "6.1.0" | |||
| "node-fetch": "2.1.2", | |||
There was a problem hiding this comment.
is this is a safe change to make? Seems like there are some actual incompatibilities here, though I don't know if we're using any of these one way or the other.
There was a problem hiding this comment.
Looking around the changelog, I don't see any 🔥using 2.1.2. This part of v2.0.0 general changes pushed me to bump it though:
Enhance: start testing on Node.js v4.x, v6.x, v8.x LTS, as well as v9.x stable
There was a problem hiding this comment.
To be on a safe side, let's stick with 1.7.1 in this release since it isn't broken running on Node.js 8.10.0.
Add support for Node.js 8.10.