Skip to content
This repository has been archived by the owner on Jul 12, 2019. It is now read-only.

Added call to console.log or console.error #66

Merged
merged 2 commits into from
Feb 26, 2018
Merged

Conversation

mojowen
Copy link
Contributor

@mojowen mojowen commented Feb 22, 2018

Description

Adding a call to console.log (or console.error) in addition to what z.console.log already does.

Type of Changes

Type
πŸ› Bug fix
βœ“ ✨ New feature
πŸ”¨ Refactoring
πŸ”— Update dependencies
πŸ“œ Docs

Related Issue

Takes care of PDE-70

Before / Current Behavior

Currently does not log to console.log

After / New Behavior

Logs to console.log

Testing Instructions

Didn't see any unit tests - happy to add some - but here's how I tested things in the node console

const injectZObject = require('./src/app-middlewares/before/z-object');
const z = injectZObject({ _zapier: { promises: [], logger: () => {} } }).z
z.console.log('I will be console logged')

TODOs

  • Add tests
  • All tests passing

@mojowen mojowen requested a review from xavdid February 22, 2018 01:37
@mojowen mojowen force-pushed the PDE-70-add-console-log branch from 6a3444c to 0ac151e Compare February 22, 2018 01:43
@mojowen mojowen force-pushed the PDE-70-add-console-log branch from 7749333 to 794ebba Compare February 22, 2018 02:19
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, works like a charm!

@mojowen mojowen merged commit 9bfa342 into master Feb 26, 2018
@mojowen mojowen deleted the PDE-70-add-console-log branch February 27, 2018 21:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants