This repository has been archived by the owner on Jul 12, 2019. It is now read-only.
[PDE-724] (BREAKING) Make removeMissingValuesFrom a first class field from request #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliangcs
reviewed
Feb 25, 2019
| removeMissingValuesFrom: { | ||
| params: !!req.omitEmptyParams, | ||
| params: false, |
There was a problem hiding this comment.
Maybe we should use _.defaultsDeep because we have a nested object?
There was a problem hiding this comment.
Had considered that. I thought we agreed on this approach, but can easily change if you think it's better with _.defaultsDeep.
There was a problem hiding this comment.
Ah, totally missed it. We can keep using _.defaults here, but maybe we can drop a comment here saying something like "if any one of these defaults to true, we'll need to use _.defaultsDeep".
eliangcs
changed the title
eliangcs
approved these changes
Feb 26, 2019
xavdid
approved these changes
Mar 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This probably could have been done in the last PR that addressed this field. But now we're making it a first class field from the client, and yanking
omitEmptyParams.Jira
https://zapierorg.atlassian.net/browse/PDE-724