Merge pull request #75 from zapier/stash_file_streams_content

Raise Exception for Bad Requests When Stashing A File

src/tools/create-file-stasher.js

@@ -117,7 +117,6 @@ const createFileStasher = input => {
                 } else {
                   newBufferStringStream = response.content;
                 }
-
                 knownLength =
                   knownLength || response.getHeader('content-length');
                 const cd = response.getHeader('content-disposition');
@@ -141,8 +140,8 @@ const createFileStasher = input => {
                 fileContentType
               );
             };
-
             if (isStreamed) {
+              maybeResponse.throwForStatus();
               return maybeResponse.buffer().then(parseFinalResponse);
             } else {
               return parseFinalResponse(maybeResponse);

test/tools/file-stasher.js

@@ -4,6 +4,7 @@ const fs = require('fs');
 const path = require('path');
 
 const should = require('should');
+const nock = require('nock');
 
 const mocky = require('./mocky');
 
@@ -115,6 +116,27 @@ describe('file upload', () => {
       .catch(done);
   });
 
+  it('should throwForStatus if bad status', done => {
+    mocky.mockRpcCall(mocky.fakeSignedPostData);
+    mocky.mockUpload();
+
+    nock('http://example.com')
+      .get('/stream-bytes')
+      .reply(401);
+
+    const request = createAppRequestClient(input);
+    const file = request({
+      url: 'http://example.com/stream-bytes',
+      raw: true
+    });
+    stashFile(file)
+      .catch(err => {
+        should(err.message).containEql('Received 401 code from');
+        done();
+      })
+      .catch(done);
+  });
+
   it('should upload a resolved buffer', done => {
     mocky.mockRpcCall(mocky.fakeSignedPostData);
     mocky.mockUpload();