Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

Fix after hook in smoke test #362

Merged
merged 1 commit into from
Sep 26, 2018
Merged

Fix after hook in smoke test #362

merged 1 commit into from
Sep 26, 2018

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Sep 25, 2018 •
edited
Loading

Fixes the cleanup hook in the smoke test, where we should be using sync fs operations.

@eliangcs eliangcs requested a review from xavdid September 25, 2018 13:21
xavdid
xavdid approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want, you can make the whole after function async and await the async operations. This works too though.

@eliangcs eliangcs merged commit b65aad1 into master Sep 26, 2018
@eliangcs eliangcs deleted the sync-fs-operations branch September 26, 2018 04:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@xavdid xavdid xavdid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliangcs @xavdid