This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
Bump versions of dependencies and Node.js #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kola-er
changed the title
xavdid
approved these changes
Jun 14, 2018
CHANGELOG.md
Outdated
| ### schema | ||
| ### core | ||
|
|
||
| * (**BREAKING**) Apps with dependency zapier-platform-core=">=7.0.0" run only on Node.js `v8.10.0` in AWS Lambda. If you need to continue running on Node.js `v6.10.3`, use zapier-platform-core="<=6.1.0". |
There was a problem hiding this comment.
this is generated automatically later, can revert.
README-source.md
Outdated
| @@ -1179,7 +1179,7 @@ This makes it pretty straightforward to integrate into your testing interface. I | |||
| ```yaml | |||
| language: node_js | |||
| node_js: | |||
| - "6.10.2" | |||
| - "8.10.0" | |||
There was a problem hiding this comment.
this should be LAMBDA_VERSION so it gets autofilled.
kola-er
commented
Jun 14, 2018
README-source.md
Outdated
| @@ -1179,7 +1179,7 @@ This makes it pretty straightforward to integrate into your testing interface. I | |||
| ```yaml | |||
| language: node_js | |||
| node_js: | |||
| - "6.10.2" | |||
| - `LAMBDA_VERSION` | |||
There was a problem hiding this comment.
oh sorry, I totally spaced on this. it would be "LAMBDA_VERSION" since I believe it's just a string replace.
|
@xavdid Please final review. Thanks. |
xavdid
approved these changes
Jun 19, 2018
This was referenced Jun 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Node.js 8.10.