This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
Allow cli access to request #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exposed in hooks and after zapier/zapier#16747 it'll be exposed in the `getAccessToken` method
bryanhelmig
suggested changes
Apr 13, 2018
README-source.md
Outdated
| querystring:'key=value;key2=value2', | ||
| content:'{key:value}' | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Since these are Javascript objects, I'd do something more complete and neater like:
{
method: 'POST',
querystring: 'foo=bar&baz=qux',
headers: {
'Content-Type': 'application/json'
},
content: '{"hello": "world"}'
}There was a problem hiding this comment.
lazy me. Will fix
README-source.md
Outdated
| key: 'value' | ||
| } | ||
| } | ||
| ``` |
There was a problem hiding this comment.
As well as a matching cleaned version:
{
method: 'POST',
querystring: {
foo: 'bar',
baz: 'qux'
},
headers: {
'Content-Type': 'application/json'
},
content: {
hello: 'world'
}
}
README-source.md
Outdated
| @@ -633,6 +633,41 @@ module.exports = { | |||
| }; | |||
| ``` | |||
|
|
|||
| ### `bundle.rawRequest` | |||
| ***`bundle.rawRequest` is only available in the `perform` for web hooks and `getAccessToken` for oauth authentication methods*** | |||
There was a problem hiding this comment.
Might do > blockquote? Just a nit, don't really mind either way. /shrug
There was a problem hiding this comment.
I agree > looks better. I'd copied the formatting from the end of the bundle meta. So I've changed that too
bryanhelmig
approved these changes
Apr 16, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding documentation of
cleanedRequestandrawRequestas created in PR zapier/zapier#16747