This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
Escape line breaks when generating package.json #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `zapier convert` for an existing Zapier app with a multiline description generated an invalid JSON in package.json which then causes the whole process to fail with something similar to ``` Error! Unexpected token in JSON at position 149 ```
|
Thanks for the contribution @bradleypriest! We'll need you to sign the CLA (@bcooksey is that bot around?) but once your changes are approved by the engineer who has been working on the converter, you should be good to go! |
|
Kicked it off. Should be able to click the details link in the checks section now @bradleypriest |
eliangcs
approved these changes
Jan 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
zapier convertfor an existing Zapier app with a multiline description generated an invalid JSON in package.json which then causes the whole process to fail with something similar to