This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
use actual json endpoint for scaffold triggers #215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the scaffolded steps all used
http://example.com/<key>.json
which looks nice, but returns busted html whenever it's called. Instead, I switched the scaffolded steps to use https://jsonplaceholder.typicode.com, which is a test utility that supports all manner of endpoints and verbs. I'm using the default public stuff right now, but it's open source and we could customize it and host it ourselves if we want. The biggest advantage to self-hosting would be we could create wildcard endpoints to match the scaffold name (/whatever
would work), but this seems straightforward enough as not to confuse devs.Now, the scaffolded tests actually run!
Before:
After: