Skip to content
This repository has been archived by the owner on Jun 27, 2019. It is now read-only.

zapier convert: Exclude input fields from bundle.inputData if send_in_json is false #204

Merged
merged 4 commits into from
Dec 25, 2017

Conversation

eliangcs
Copy link
Member

@eliangcs eliangcs commented Dec 12, 2017

This PR adds support for selectively excluding input fields from bundle.inputData in creates that don't have _write nor _pre_write scripting, where the fields have send_in_json set to false. In WB, these fields weren't included, and in the current conversion they are.

Example app to try out: 83073

BTW, this PR also fixes the crash issue when a field label contains a single quote.

…_json is false

Supports selectively excluding input fields from bundle.inputData in
creates that don't have _write nor _pre_write scripting, where the
fields have send_in_json set to false. In WB, these fields weren't
included, and in the current conversion they are.
Copy link
Contributor

@xavdid xavdid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable!

Isn't there a similar checkbox for triggers and searches as well? though it's been a while, there might not be.

@eliangcs
Copy link
Member Author

@xavdid thanks for the reminder! I just double checked. The checkbox is not available for triggers and searches.

@eliangcs eliangcs merged commit abf396e into master Dec 25, 2017
@eliangcs eliangcs deleted the convert-send-in-json branch December 25, 2017 07:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants