This repository has been archived by the owner on Jun 27, 2019. It is now read-only.
Add option to filter tests #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This looks great @FokkeZB ! Thank you so much for this.
I've added a question which I need to decide on whether this needs changes or can go as is.
src/commands/test.js
Outdated
| @@ -38,6 +38,11 @@ const test = (context) => { | |||
| commands.push(`--timeout=${global.argOpts.timeout}`); | |||
| } | |||
|
|
|||
| if (global.argOpts.grep) { | |||
| commands.push('--'); | |||
There was a problem hiding this comment.
If global.argOpts.timeout is also set, I believe this will fail, right? If so, please add a condition here, otherwise, please ignore my comment.
There was a problem hiding this comment.
Stuuuuupid mistake, fixed.
BrunoBernardino
approved these changes
Nov 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes on
--grepto mocha so that you can filter tests to run.