Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add helm chart value to render tolerations in the controller #63

Merged
merged 2 commits into from
Jul 31, 2023
Merged

feat: Add helm chart value to render tolerations in the controller #63

merged 2 commits into from
Jul 31, 2023

Conversation

Linutux42
Copy link
Contributor

This PR simply adds the possibility to configure tolerations on the controller from the helm chart.

Let me know if I missed something :)

@mplachter
Copy link
Contributor

Hi @Linutux42,

Sorry for the delay. I just need you to sign your commit so we can get this merged :)

@Linutux42
Copy link
Contributor Author

Hey @mplachter,

done ;)

@mplachter
Copy link
Contributor

I checked CI for Errors looks like these are still pending

@Linutux42
Copy link
Contributor Author

Is it better now ?

djeebus
djeebus approved these changes Jul 31, 2023
View reviewed changes
Copy link
Collaborator

@djeebus djeebus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@djeebus djeebus merged commit 79e9d20 into zapier:main Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djeebus djeebus djeebus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Linutux42 @mplachter @djeebus