Add error response to make it esay to figure out the failure root cause

Signed-off-by: zane-neo <[email protected]>
zane-neo · Jun 14, 2024 · cdfc42a · cdfc42a
1 parent 0ed00b2
commit cdfc42a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/plugin/src/test/java/org/opensearch/ml/rest/RestBedRockInferenceIT.java b/plugin/src/test/java/org/opensearch/ml/rest/RestBedRockInferenceIT.java
@@ -114,7 +114,6 @@ public void test_bedrock_multimodal_model() throws Exception {
         for (Map.Entry<String, Object> templateEntry : templateMap.entrySet()) {
             String bedrockEmbeddingModelName = "bedrock embedding model " + randomAlphaOfLength(5);
             String testCaseName = templateEntry.getKey();
-            String errorMsg = String.format(Locale.ROOT, "Failing test case name: %s", testCaseName);
             String modelId = registerRemoteModel(
                 String
                     .format(
@@ -131,6 +130,7 @@ public void test_bedrock_multimodal_model() throws Exception {
             TextDocsInputDataSet inputDataSet = TextDocsInputDataSet.builder().docs(List.of("hello", imageBase64)).build();
             MLInput mlInput = MLInput.builder().inputDataset(inputDataSet).algorithm(FunctionName.TEXT_EMBEDDING).build();
             Map inferenceResult = predictTextEmbeddingModel(modelId, mlInput);
+            String errorMsg = String.format(Locale.ROOT, "Failing test case name: %s, inference result: %s", testCaseName, gson.toJson(inferenceResult));
             assertTrue(errorMsg, inferenceResult.containsKey("inference_results"));
             List output = (List) inferenceResult.get("inference_results");
             assertEquals(errorMsg, 1, output.size());
@@ -164,7 +164,6 @@ public void test_bedrock_multimodal_model_empty_imageInput() throws Exception {
         for (Map.Entry<String, Object> templateEntry : templateMap.entrySet()) {
             String bedrockEmbeddingModelName = "bedrock embedding model " + randomAlphaOfLength(5);
             String testCaseName = templateEntry.getKey();
-            String errorMsg = String.format(Locale.ROOT, "Failing test case name: %s", testCaseName);
             String modelId = registerRemoteModel(
                 String
                     .format(
@@ -181,6 +180,7 @@ public void test_bedrock_multimodal_model_empty_imageInput() throws Exception {
             TextDocsInputDataSet inputDataSet = TextDocsInputDataSet.builder().docs(List.of("hello")).build();
             MLInput mlInput = MLInput.builder().inputDataset(inputDataSet).algorithm(FunctionName.TEXT_EMBEDDING).build();
             Map inferenceResult = predictTextEmbeddingModel(modelId, mlInput);
+            String errorMsg = String.format(Locale.ROOT, "Failing test case name: %s, inference result: %s", testCaseName, gson.toJson(inferenceResult));
             assertTrue(errorMsg, inferenceResult.containsKey("inference_results"));
             List output = (List) inferenceResult.get("inference_results");
             assertEquals(errorMsg, 1, output.size());
@@ -214,7 +214,6 @@ public void test_bedrock_multimodal_model_empty_imageInput_null_textInput() thro
         for (Map.Entry<String, Object> templateEntry : templateMap.entrySet()) {
             String bedrockEmbeddingModelName = "bedrock embedding model " + randomAlphaOfLength(5);
             String testCaseName = templateEntry.getKey();
-            String errorMsg = String.format(Locale.ROOT, "Failing test case name: %s", testCaseName);
             String modelId = registerRemoteModel(
                 String
                     .format(
@@ -233,6 +232,7 @@ public void test_bedrock_multimodal_model_empty_imageInput_null_textInput() thro
             TextDocsInputDataSet inputDataSet = TextDocsInputDataSet.builder().docs(input).build();
             MLInput mlInput = MLInput.builder().inputDataset(inputDataSet).algorithm(FunctionName.TEXT_EMBEDDING).build();
             Map inferenceResult = predictTextEmbeddingModel(modelId, mlInput);
+            String errorMsg = String.format(Locale.ROOT, "Failing test case name: %s, inference result: %s", testCaseName, gson.toJson(inferenceResult));
             assertTrue(errorMsg, inferenceResult.containsKey("status"));
             assertTrue(errorMsg, String.valueOf(inferenceResult.get("status")).contains("400"));
             assertTrue(errorMsg, inferenceResult.containsKey("error"));