Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
vfio/iova_bitmap: Fix PAGE_SIZE unaligned bitmaps
[ Upstream commit f38044e ] iova_bitmap_set() doesn't consider the end of the page boundary when the first bitmap page offset isn't zero, and wrongly changes the consecutive page right after. Consequently this leads to missing dirty pages from reported by the device as seen from the VMM. The current logic iterates over a given number of base pages and clamps it to the remaining indexes to iterate in the last page. Instead of having to consider extra pages to pin (e.g. first and extra pages), just handle the first page as its own range and let the rest of the bitmap be handled as if it was base page aligned. This is done by changing iova_bitmap_mapped_remaining() to return PAGE_SIZE - pgoff (on the first bitmap page), and leads to pgoff being set to 0 on following iterations. Fixes: 58ccf01 ("vfio: Add an IOVA bitmap support") Reported-by: Avihai Horon <[email protected]> Tested-by: Avihai Horon <[email protected]> Signed-off-by: Joao Martins <[email protected]> Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alex Williamson <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
- Loading branch information