-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ZNTA-2390): run all tests if PR description contains allFuncTests #846
Conversation
Reviewed 1 of 1 files at r1. Comments from Reviewable |
Codecov Report
@@ Coverage Diff @@
## master #846 +/- ##
============================================
+ Coverage 34% 34.19% +0.19%
- Complexity 5921 6006 +85
============================================
Files 1613 1613
Lines 64341 65619 +1278
Branches 7503 7793 +290
============================================
+ Hits 21876 22436 +560
- Misses 40482 41179 +697
- Partials 1983 2004 +21
Continue to review full report at Codecov.
|
Despite putting allFuncTests in the PR description (and title), all functional tests were not run. Looks like we have two problems to solve before this is useful:
It looks like the method above doesn't handle rate limit exceptions well - this probably prevents any PR details from being copied to the Jenkins job at all. getSourceBranchLabel should probably catch any exception, log it, and try to continue. |
Blocked by (testing for) zanata/zanata-pipeline-library#8 |
Might as well treat the limitations of zanata-pipeline-library as a separate issue and merge this. In the meantime it may not quite work as intended, but at least we won't have a branch sitting around. |
JIRA issue URL: https://zanata.atlassian.net/browse/ZNTA-2390
Jenkins: allFuncTests
Checklist
See Zanata Development Guidelines more for information.
This template can be updated in .github/PULL_REQUEST_TEMPLATE.md