Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ZNTA-2390): run all tests if PR description contains allFuncTests #846

Merged
merged 2 commits into from
Jun 12, 2018

Conversation

seanf
Copy link
Contributor

@seanf seanf commented May 25, 2018

JIRA issue URL: https://zanata.atlassian.net/browse/ZNTA-2390

Jenkins: allFuncTests

Checklist

  • JIRA link
  • Check target branch
  • Make sure all commit statuses are green or otherwise documented reasons to ignore
  • QA needs to evaluate against the JIRA ticket
  • Changed files and commits make sense for this PR

See Zanata Development Guidelines more for information.


This template can be updated in .github/PULL_REQUEST_TEMPLATE.md

@zubot
Copy link
Member

zubot commented May 25, 2018

This change is Reviewable

@djansen-redhat
Copy link
Contributor

:lgtm:


Reviewed 1 of 1 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@codecov
Copy link

codecov bot commented May 25, 2018

Codecov Report

Merging #846 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #846      +/-   ##
============================================
+ Coverage        34%   34.19%   +0.19%     
- Complexity     5921     6006      +85     
============================================
  Files          1613     1613              
  Lines         64341    65619    +1278     
  Branches       7503     7793     +290     
============================================
+ Hits          21876    22436     +560     
- Misses        40482    41179     +697     
- Partials       1983     2004      +21
Impacted Files Coverage Δ Complexity Δ
...rontend/src/app/components/RejectionsForm/index.js 67.79% <0%> (-12.21%) 0% <0%> (ø)
...ntend/src/app/containers/UserProfile/DayMatrix.jsx 22.72% <0%> (-5.06%) 0% <0%> (ø)
.../main/java/org/zanata/model/HProjectIteration.java 21.36% <0%> (-3.64%) 5% <0%> (+2%)
...end/src/app/editor/reducers/header-data-reducer.js 84.37% <0%> (-2.59%) 0% <0%> (ø)
...nd/src/app/editor/reducers/review-trans-reducer.js 76.47% <0%> (-2.11%) 0% <0%> (ø)
...rvices/src/main/java/org/zanata/util/HtmlUtil.java 88.88% <0%> (-2.03%) 4% <0%> (+2%)
...rontend/src/app/containers/Explore/GroupTeaser.jsx 21.73% <0%> (-1.8%) 0% <0%> (ø)
server/zanata-frontend/src/app/require-all.test.ts 20.83% <0%> (-0.91%) 0% <0%> (ø)
...er/zanata-frontend/src/app/utils/GlossaryHelper.js 11.11% <0%> (-0.8%) 0% <0%> (ø)
...anata-frontend/src/app/editor/utils/phrase-util.ts 69.23% <0%> (-0.77%) 0% <0%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f992d75...28270eb. Read the comment docs.

@seanf
Copy link
Contributor Author

seanf commented May 25, 2018

Despite putting allFuncTests in the PR description (and title), all functional tests were not run.

Looks like we have two problems to solve before this is useful:

It looks like the method above doesn't handle rate limit exceptions well - this probably prevents any PR details from being copied to the Jenkins job at all. getSourceBranchLabel should probably catch any exception, log it, and try to continue.

@seanf
Copy link
Contributor Author

seanf commented Jun 12, 2018

Blocked by (testing for) zanata/zanata-pipeline-library#8

@seanf
Copy link
Contributor Author

seanf commented Jun 12, 2018

Might as well treat the limitations of zanata-pipeline-library as a separate issue and merge this. In the meantime it may not quite work as intended, but at least we won't have a branch sitting around.

@seanf seanf removed the On hold label Jun 12, 2018
@seanf seanf merged commit c98bd78 into master Jun 12, 2018
@seanf seanf deleted the allFuncTests branch June 12, 2018 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants