Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance: Refactor YAML for better maintainability. #369

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

mgruner
Copy link
Collaborator

@mgruner mgruner commented Aug 25, 2023

Attempt to reduce redundancy in the docker-compose.yml file by using YAML fragments and docker extensions. This should make it easier to add more variables in future, as suggested in #346.

fliebe92
fliebe92 previously approved these changes Aug 25, 2023
@mgruner
Copy link
Collaborator Author

mgruner commented Aug 25, 2023

This should not make any functional changes, with one exception: zammad-scheduler and zammad-websocket no longer depend on zammad-railsserver, but instead on redis/memcached/postgresql directly. That simplifies definition and I see no reason why they should wait for the web server. Please let me know if you disagree.

@mgruner mgruner merged commit cb6a82d into master Aug 28, 2023
4 checks passed
@mgruner mgruner deleted the refactor-yaml branch August 28, 2023 06:00
floriankessler pushed a commit to floriankessler/zammad-docker-compose that referenced this pull request Jan 5, 2024
* Maintenance: Refactor YAML for better maintainability.

* Simplify service dependency definition.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants