Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #359 - Backup is constantly running. #367

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Fixes #359 - Backup is constantly running. #367

merged 1 commit into from
Aug 25, 2023

Conversation

mgruner
Copy link
Collaborator

@mgruner mgruner commented Aug 24, 2023

  • Fixes Backup is constantly running #359 by making sure the variable BACKUP_TIME is always set, even if not passed to the container.
  • Makes sure all database related variables get passed to the backup container (e.g. host and port), and also pre-populated in the backup script if missing.
  • Unify naming of the password parameter to POSTGRESQL_PASS like in the entrypoint.
  • Small English grammar improvement.

t-shehab
t-shehab approved these changes Aug 25, 2023
View reviewed changes
Copy link

@t-shehab t-shehab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@mgruner mgruner merged commit 755c756 into master Aug 25, 2023
4 checks passed
@mgruner mgruner deleted the fix-backup-script branch August 25, 2023 09:34
floriankessler pushed a commit to floriankessler/zammad-docker-compose that referenced this pull request Jan 5, 2024
@mgruner @floriankessler
Fixes zammad#359 - Backup is constantly running. (zammad#367)
b2050ee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-shehab t-shehab t-shehab approved these changes

@monotek monotek Awaiting requested review from monotek

@MrGeneration MrGeneration Awaiting requested review from MrGeneration

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Backup is constantly running
2 participants
@mgruner @t-shehab