Fix clone_with_wale on pg13+ when recovery_time in future #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PostgreSQL 13 changed its behavior when the recovery target is unreachable. While old versions were finishing the recovery and promoting Postgres, starting from 13 Postgres complains "recovery ended before configured recovery target was reached" in logs and exits. As a result, the clone completely fails. In order to retain the same behavior as with old versions, the `maybe_pg_upgrade.py` will always start point-in-time recovery (even if there is no major upgrade required). If it failed, for PostgreSQL 13+ it will check a few last log lines and if they contain the error about the recovery target not reached, it will reset all recovery targets and start the postgres up one more time. The next failure is fatal.
|
👍 |
|
👍 |
1 similar comment
|
👍 |
|
I haven't run the version of spilo where this pr is included but I was just wondering if this works even if I have disabled csv logging, aka set the following in the postgres configuration ? |
No, it won't work. Unfortunately, there is no universal solution to this problem. If you don't rely on CSV logs I can only suggest not set recovery target in the future. |
|
Thanks for the reply, I'll make sure to make a note of this 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgreSQL 13 changed its behavior when the recovery target is unreachable. While old versions were finishing the recovery and
promoting Postgres, starting from 13 Postgres complains "recovery ended before configured recovery target was reached" in logs and exits. As a result, the clone completely fails.
In order to retain the same behavior as with old versions, the
maybe_pg_upgrade.pywill always start point-in-time recovery (even if there is no major upgrade required).If it failed, for PostgreSQL 13+ it will check a few last log lines and if they contain the error about the recovery target not reached,
it will reset all recovery targets and start the postgres up one more time. The next failure is fatal.