skipper: improve createDataClients errors #3260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AlexanderYastrebov
commented
Oct 1, 2024
AlexanderYastrebov
commented
- add context message to returned errors
- remove duplicate logging - errors will be logged by the caller (main)
* add context message to returned errors * remove duplicate logging - errors will be logged by the caller (main) Signed-off-by: Alexander Yastrebov <[email protected]>
| @@ -1070,8 +1068,7 @@ func createDataClients(o Options, cr *certregistry.CertRegistry) ([]routing.Data | |||
| if o.InlineRoutes != "" { | |||
| ir, err := routestring.New(o.InlineRoutes) | |||
| if err != nil { | |||
| log.Error("error while parsing inline routes", err) | |||
There was a problem hiding this comment.
This log was also missing whitespace:
$ ./bin/skipper -inline-routes='* -> '
[APP]INFO[0000] Expose metrics in codahale format
[APP]ERRO[0000] error while parsing inline routesparse failed after token ->, position 5: syntax error
[APP]FATA[0000] parse failed after token ->, position 5: syntax error
|
👍 |
1 similar comment
|
👍 |
This was referenced Oct 1, 2024
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Oct 8, 2024
* zalando/skipper#3260 * zalando/skipper#3259 * zalando/skipper#3266 * zalando/skipper#3263 * zalando/skipper#3264 * zalando/skipper#3265 * zalando/skipper#3257 Canary was updated in those PRs: * #8295 * #8309 Signed-off-by: Roman Zavodskikh <[email protected]>
Pushpalanka
pushed a commit
that referenced
this pull request
Oct 11, 2024
* add context message to returned errors * remove duplicate logging - errors will be logged by the caller (main) Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.