Fix list formatting in filters.md #3188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing! Can you make DCO happy by signing the commit (see https://github.com/zalando/skipper/pull/3188/checks?check_run_id=28761545790) |
Hmm, I made the edit in the Github UI, which did sign it for me, though it did not add a "signed-off-by" line. |
|
will make a PR to fix staticchecks |
|
The pipeline fix is merged, can you rebase? |
The Markdown processor used on the reference docs (e.g. https://opensource.zalando.com/skipper/reference/filters/#awssigv4) requires an empty line before a list to recognize it as such (and not have the content part of the paragraph before it). This adds two such line breaks. (The difference is not visible on the Github preview, as its processor doesn't require the empty line.) Signed-off-by: Paul Ebermann <[email protected]>
|
👍 |
|
Looks like now all the builds are green. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Markdown processor used on the reference docs (e.g. https://opensource.zalando.com/skipper/reference/filters/#awssigv4) requires an empty line before a list to recognize it as such (and not have the content part of the paragraph before it). This adds two such line breaks.
(The difference is not visible on the Github preview, as its processor doesn't require the empty line.)