filters/auth: add second login redirect stub placeholder #3161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Login redirect stub introduced by #3028 uses `{{authCodeURL}}` placeholder that is a valid mustache template and hence inconvenient to use from mustache templates. This change adds a second `{authCodeURL}` placeholder and `X-Auth-Code-Url` response header. Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
filters/auth/grant-login-redirect-placeholder
branch
from
0869453
to
ebe6930
Compare
|
👍 |
|
👍 |
AlexanderYastrebov
deleted the
filters/auth/grant-login-redirect-placeholder
branch
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jul 25, 2024
* zalando/skipper#3167 * zalando/skipper#3166 * zalando/skipper#3165 * zalando/skipper#3164 * zalando/skipper#3162 * zalando/skipper#3161 * zalando/skipper#3159 * zalando/skipper#3158 * zalando/skipper#3070 * zalando/skipper#3140 * zalando/skipper#3155 [Changes](zalando/skipper@v0.21.150...v0.21.161) Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jul 25, 2024
* zalando/skipper#3167 * zalando/skipper#3166 * zalando/skipper#3165 * zalando/skipper#3164 * zalando/skipper#3162 * zalando/skipper#3161 * zalando/skipper#3159 * zalando/skipper#3158 * zalando/skipper#3070 * zalando/skipper#3140 * zalando/skipper#3155 [Changes](zalando/skipper@v0.21.150...v0.21.161) Signed-off-by: Alexander Yastrebov <[email protected]>
RomanZavodskikh
pushed a commit
to zalando-incubator/kubernetes-on-aws
that referenced
this pull request
Jul 26, 2024
* zalando/skipper#3167 * zalando/skipper#3166 * zalando/skipper#3165 * zalando/skipper#3164 * zalando/skipper#3162 * zalando/skipper#3161 * zalando/skipper#3159 * zalando/skipper#3158 * zalando/skipper#3070 * zalando/skipper#3140 * zalando/skipper#3155 [Changes](zalando/skipper@v0.21.150...v0.21.161) Signed-off-by: Roman Zavodskikh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Login redirect stub introduced by #3028 uses
{{authCodeURL}}placeholder which is a valid mustache tag and hence inconvenient to use from mustache templates.This change adds a second
{authCodeURL}placeholder andX-Auth-Code-Urlresponse header.