Temporary skip tests using net/redistest #2458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
changed the title
AlexanderYastrebov
force-pushed
the
build/skip-redis-tests
branch
from
862a39a
to
fd6b249
Compare
|
👍 |
net/redistest/redistest.go
Outdated
| @@ -15,6 +15,9 @@ func NewTestRedis(t testing.TB) (address string, done func()) { | |||
| } | |||
|
|
|||
| func NewTestRedisWithPassword(t testing.TB, password string) (address string, done func()) { | |||
|
|
|||
| t.Skip("https://github.com/testcontainers/testcontainers-go/issues/1359") | |||
There was a problem hiding this comment.
Can we set some deadline after which this skip won't work?
Something like this:
if time.Now() < time.Parse("2023-Sep-01", "2014-Feb-04") {
t.Skip("https://github.com/testcontainers/testcontainers-go/issues/1359")
}
There was a problem hiding this comment.
Good idea, fixed.
Redis testcontainer fails to start due to testcontainers/testcontainers-go#1359 caused by golang/go#61076 and we can not pin cdp-runtime/go to a working patch version before 1.20.6 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
build/skip-redis-tests
branch
from
fd6b249
to
d1e1f9d
Compare
| @@ -15,6 +15,11 @@ func NewTestRedis(t testing.TB) (address string, done func()) { | |||
| } | |||
|
|
|||
| func NewTestRedisWithPassword(t testing.TB, password string) (address string, done func()) { | |||
|
|
|||
| if fixDeadline, _ := time.Parse("2006-01-02", "2023-08-01"); time.Now().Before(fixDeadline) { | |||
There was a problem hiding this comment.
Could use time.DateOnly but its only available since go1.20
|
👍 |
| @@ -15,6 +15,11 @@ func NewTestRedis(t testing.TB) (address string, done func()) { | |||
| } | |||
|
|
|||
| func NewTestRedisWithPassword(t testing.TB, password string) (address string, done func()) { | |||
|
|
|||
| if fixDeadline, _ := time.Parse("2006-01-02", "2023-08-01"); time.Now().Before(fixDeadline) { | |||
There was a problem hiding this comment.
I don't get the relevance of 2006 date
There was a problem hiding this comment.
Check out this https://pkg.go.dev/time#Parse
|
Note: |
|
Merging as testcontainers fix may take a while |
|
👍 |
AlexanderYastrebov
added a commit
that referenced
this pull request
Aug 1, 2023
Followup on #2458 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Aug 1, 2023
Followup on #2458 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Aug 1, 2023
Followup on #2458 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Aug 6, 2023
* update testcontainers to fix goroutine leak (see testcontainers/testcontainers-go#1441) [changes](testcontainers/testcontainers-go@v0.20.1...d1c291e) * enable redis tests back Updates #2458 Closes #2496 Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
added a commit
that referenced
this pull request
Aug 6, 2023
* update testcontainers to fix goroutine leak (see testcontainers/testcontainers-go#1441) [changes](testcontainers/testcontainers-go@v0.20.1...d1c291e) * enable redis tests back Updates #2458 Closes #2496 Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redis testcontainer fails to start due to testcontainers/testcontainers-go#1359 caused by golang/go#61076 and we can not pin cdp-runtime/go to a working patch version before 1.20.6