Adds h2c support #1868
Closed
Adds h2c support #1868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderYastrebov
force-pushed
the
h2c
branch
from
b7a5587 to
b019978
Compare
szuecs
reviewed
Oct 14, 2021
|
👍 |
|
From my side great first step to support h2c as a server handler! |
AlexanderYastrebov
force-pushed
the
h2c
branch
5 times, most recently
from
d3103d1 to
0d9432d
Compare
Enables HTTP/2 connections over cleartext TCP with Prior Knowledge (RFC 7540 3.4). The implementation is based on the golang.org/x/net/http2/h2c and workarounds several issues: * golang/go#38064 * golang/go#26682 See h2c package docs for details. Signed-off-by: Alexander Yastrebov <[email protected]>
AlexanderYastrebov
force-pushed
the
h2c
branch
from
0d9432d to
f2b780b
Compare
any update about h2c ? |
|
@tsingson I think we should wait for golang/net#139 being merged and released, if not it's not reasonable to have h2c support in Go. |
thanks for update. |
Comment on lines
+131
to
+149
| func (h *h2cHandler) Shutdown(ctx context.Context) error { | ||
| serr := h.s1.Shutdown(ctx) | ||
|
|
||
| timer := time.NewTicker(500 * time.Millisecond) | ||
| defer timer.Stop() | ||
| for { | ||
| n := atomic.LoadInt64(&h.conns) | ||
| log.Debugf("h2c shutdown: %d connections", n) | ||
|
|
||
| if n == 0 { | ||
| return serr | ||
| } | ||
| select { | ||
| case <-ctx.Done(): | ||
| return ctx.Err() | ||
| case <-timer.C: | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is just waiting for connections close. Proper shutdown should send goaway
- https://github.com/golang/net/blob/304cc91b19ae873219f3d0807c8533267629cf2e/http2/server.go#L232-L241
- https://github.com/golang/net/blob/304cc91b19ae873219f3d0807c8533267629cf2e/http2/server.go#L1384-L1394
(i.e. golang/go#26682 is not solved)
|
|
Closing in favour of #2480 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables HTTP/2 connections over cleartext TCP with Prior Knowledge (RFC 7540 3.4).
The implementation is based on the golang.org/x/net/http2/h2c and workarounds several issues:
x/net/http2/h2c: support closure of all connections and graceful shutdown golang/go#26682Adds h2c support #1868 (review)See h2c package docs for details.
Signed-off-by: Alexander Yastrebov [email protected]