Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skipper build for Go 1.13 #1175

Merged
merged 3 commits into from
Sep 4, 2019
Merged

Update skipper build for Go 1.13 #1175

merged 3 commits into from
Sep 4, 2019

Conversation

mikkeloscar
Copy link
Member

Updates skipper build for go 1.13

I basically ran go mod tidy with Go 1.13 to ensure that there are no changes to go.mod during build which would make the build "dirty" in git. :)

Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
@mikkeloscar
Copy link
Member Author

Added an update which moves the flag parsing to be called in func main rather than in func init. Without this change the following fails:

go test -race -test.short -run ^Test github.com/zalando/skipper/cmd/skipper
flag provided but not defined: -test.testlogfile
Usage of /tmp/go-build634583681/b001/skipper.test:

I'm not completely sure on the impact of this change but considering it's bad practice to do a lot of things in init causing problems like this, it probably makes sense :)

The test.testlogfile flag comes from: https://github.com/golang/go/blob/befa17c5f4591e180e5034fd4e8ca508f52dc7bc/src/cmd/go/internal/test/test.go#L1122

@szuecs
Copy link
Member

szuecs commented Sep 4, 2019

Disabled staticcheck for now, upstream issue dominikh/go-tools#575

@szuecs
Copy link
Member

szuecs commented Sep 4, 2019

Go 1.13 has TLS1.3 #745

@szuecs
Copy link
Member

szuecs commented Sep 4, 2019

👍

1 similar comment
@mikkeloscar
Copy link
Member Author

👍

@mikkeloscar mikkeloscar merged commit e477935 into master Sep 4, 2019
@mikkeloscar mikkeloscar deleted the go-mod-tidy-1.13 branch September 4, 2019 10:59
@szuecs szuecs restored the go-mod-tidy-1.13 branch September 4, 2019 11:27
@szuecs szuecs deleted the go-mod-tidy-1.13 branch September 4, 2019 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants