-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAuth2CallbackPath using https when no TLS is defined #2898
Comments
Hello, please check whether |
Great this works, thanks. Couldn't see this in the docs? |
AlexanderYastrebov
added a commit
that referenced
this issue
Feb 1, 2024
Followup on #2203 Followup on #2244 Followup on #2457 Updates #2898 Signed-off-by: Alexander Yastrebov <[email protected]>
Created #2899 |
AlexanderYastrebov
added a commit
that referenced
this issue
Feb 5, 2024
Followup on #2203 Followup on #2244 Followup on #2457 Updates #2898 Signed-off-by: Alexander Yastrebov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When running locally and using
OAuth2CallbackPath
-/callback
It will passhttps://
protocol in the url callback when the server TLS settings are not found and defaults to http.Logs for TLS:
Route:
To Reproduce
Run from localhost with no TLS config, add the callback uri, set your oauth2 provider callback to be
http://localhost/callback
Expected behavior
Not to pass
https://
and usehttp://
when no TLS config definedObserved behavior
https://localhost/callback
is being passed, which doesn't match the redirect uri on the oauth2 provider.The text was updated successfully, but these errors were encountered: