routing: refactor update id logging (#3116)

Increment update id only on update receival instead of each loop cycle which results in odd update id values due to second select case branch. Follow up on #3112 Signed-off-by: Alexander Yastrebov <[email protected]>
zalando · Jun 18, 2024 · 7da6fc6 · 7da6fc6
1 parent 355f835
commit 7da6fc6
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/routing/datasource.go b/routing/datasource.go
@@ -542,14 +542,16 @@ func receiveRouteMatcher(o Options, out chan<- *routeTable, quit <-chan struct{}
 		rt           *routeTable
 		outRelay     chan<- *routeTable
 		updatesRelay <-chan []*eskip.Route
+		updateId     int
 	)
 	updatesRelay = updates
-	for id := 1; ; id++ {
+	for {
 		select {
 		case defs := <-updatesRelay:
+			updateId++
 			start := time.Now()
 
-			o.Log.Infof("route settings received, id: %d", id)
+			o.Log.Infof("route settings received, id: %d", updateId)
 
 			for i := range o.PreProcessors {
 				defs = o.PreProcessors[i].Do(defs)
@@ -585,7 +587,7 @@ func receiveRouteMatcher(o Options, out chan<- *routeTable, quit <-chan struct{}
 			})
 
 			rt = &routeTable{
-				id:            id,
+				id:            updateId,
 				m:             m,
 				routes:        routes,
 				validRoutes:   validRoutes,