Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of pod environment config map to NamespacedName #870

Merged
merged 4 commits into from
Mar 25, 2020

Conversation

FxKu
Copy link
Member

@FxKu FxKu commented Mar 19, 2020

Change type of PodEnvironmentConfigMap to NamespacedName to allow this config map in a namespace other than where the operator runs. If the ConfigMap isn't found in the configured default namespace than the operator looks up it's own namespace (if different) to have the same behavior as before.

addresses #781

@FxKu FxKu added this to the 1.5 milestone Mar 19, 2020
@FxKu FxKu changed the title Pod env config map ns Change type of pod environment config map to NamespacedName Mar 19, 2020
@sdudoladov
Copy link
Member

👍

@frittentheke
Copy link
Contributor

@FxKu this is very cool thanks for changing this so quickly.

May I kindly ask if you plan on adding the propagation of those ENV variables from the configmap to all containers as well? (#781)

@FxKu
Copy link
Member Author

FxKu commented Mar 24, 2020

@frittentheke no concrete plans, yet. It's not on our current to do list. Shouldn't be too hard I guess. You still have the chance to open a PR :)

@sdudoladov
Copy link
Member

👍

1 similar comment
@FxKu
Copy link
Member Author

FxKu commented Mar 25, 2020

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants