Implement runner for e2e tests #548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 24, 2019 17:04
sdudoladov
requested review from
avaczi,
CyberDem0n,
erthalion,
FxKu and
Jan-M
as code owners
added 23 commits
April 24, 2019 17:13
sdudoladov
changed the title
|
@CyberDem0n your review will be much appreciated |
sdudoladov
commented
May 24, 2019
e2e/tests/test_e2e.py
Outdated
| self. wait_for_pod_start("name=postgres-operator") | ||
| # HACK operator must register CRD / add existing PG clusters after pod start up | ||
| # for local execution ~ 10 seconds suffices | ||
| time.sleep(30) |
There was a problem hiding this comment.
this is sadly not a solution: Travis build fails but local one succeed.
does anyone has other ideas on how to circumvent the issue ?
CyberDem0n
reviewed
May 29, 2019
e2e/tests/test_e2e.py
Outdated
|
|
||
| # submit the most recent operator image built on the Docker host | ||
| with open("manifests/postgres-operator.yaml", 'r+') as f: | ||
| operator_deployment = yaml.load(f, Loader=yaml.Loader) |
There was a problem hiding this comment.
yaml.load is unsafe, it is better to use yaml.safe_load
|
|
||
| with open("manifests/complete-postgres-manifest.yaml", 'r+') as f: | ||
| pg_manifest = yaml.load(f, Loader=yaml.Loader) | ||
| pg_manifest["metadata"]["namespace"] = self.namespace |
There was a problem hiding this comment.
IIRC, one can specify the namespace as kubectl parameters, kubectl create -f foo.yaml --namespace=bar
e2e/tests/test_e2e.py
Outdated
| replica_pod_nodes = [] | ||
| podsList = self.api.core_v1.list_namespaced_pod(namespace, label_selector=pod_labels) | ||
| for pod in podsList.items: | ||
| if ('spilo-role', 'master') in pod.metadata.labels.items(): |
There was a problem hiding this comment.
if pod.metadata.labels.get('spilo-role') == 'master'
e2e/tests/test_e2e.py
Outdated
| k8s.wait_for_pod_start('spilo-role=replica') | ||
|
|
||
| new_master_node, new_replica_nodes = k8s.get_spilo_nodes(labels) | ||
| self.assertTrue(current_master_node != new_master_node, |
e2e/tests/test_e2e.py
Outdated
| self.assertTrue(job.metadata.name == "logical-backup-acid-minimal-cluster", | ||
| "Expected job name {}, found {}" | ||
| .format("logical-backup-acid-minimal-cluster", job.metadata.name)) | ||
| self.assertTrue(job.spec.schedule == schedule, |
e2e/tests/test_e2e.py
Outdated
|
|
||
| labels = 'version=acid-minimal-cluster' | ||
| while self.count_pods_with_label(labels) != number_of_instances: | ||
| pass |
e2e/tests/test_e2e.py
Outdated
|
|
||
| def wait_for_logical_backup_job(self, expected_num_of_jobs): | ||
| while (len(self.get_logical_backup_job().items) != expected_num_of_jobs): | ||
| pass |
sdudoladov
commented
Jun 4, 2019
| current_master_node, failover_targets = k8s.get_spilo_nodes(labels) | ||
| num_replicas = len(failover_targets) | ||
|
|
||
| # if all pods live on the same node, failover will happen to other worker(s) |
There was a problem hiding this comment.
i'd expand this comment to better explain why we can have len(failover_targets) == 0
- single pod clusters (e.g. in test environments) - a new master pod must be started on another worker node meaning longer downtimes for such clusters
- clusters that have master/replica on the same node due to unused pod anti-affinity -> a new replica must be started on another worker node for a failover to take place.
- other clusters -> failover takes place /
failover_targetsnot empty
sdudoladov
commented
Jun 4, 2019
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
early work on #475