-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add secret mount to operator #535
Conversation
Have you seen #481 ? |
yes but i think this tackles an other problem edit: well on the second look it tries to tackle the same problem but in a completely different way. |
d94d6f0
to
52dee56
Compare
We keep poorly reinventing pod spec, when is the time to stop? #479 |
@redbaron i'm with you, in the end this is just convenience function for user who don't want to create a whole pod spec |
As we discussed in #479, most likely we would need to have both "modes" - full spec and not full spec. In this sense I believe it makes sense to have this feature for the second mode, what do you think? |
Looks good to me. @sdudoladov @FxKu |
@Shinzu could you please rebase and resolve the conflicts? |
@Shinzu can you please rebase and then we will merge this PR |
rebase done |
👍 |
hm, for some reason the config parameters are in single quotes again? |
@FxKu @sdudoladov re applied the lost changes |
👍 |
1 similar comment
👍 |
Hi! |
hello, this file just looks like a normal credential file for aws or gcp eg https://docs.aws.amazon.com/sdk-for-go/v1/developer-guide/configuring-sdk.html |
i still do not completely see the full image for getting wal-e to work with baremetal clusters.
So one mounts a file with the credentials, this is placed inside the pod but unused, unless i configure env vars to pick up that file. But, when looking at the documentation of wal-e, only gcp has a variable ("GOOGLE_APPLICATION_CREDENTIALS") for that. AWS doesn't. |
The behavior of this PR is slightly different than the behavior of injecting these values from the configmap. Mainly, the secret object must live in the namespace where the postgresql object is, and not the operator.. Ideally, for our usecase, we'd specify cloud credentials in the postgres-operator namespace, and the operator would add them to the existing secret that gets created, or to a new cloud credentials secret object. |
First initial commit for adding cloud secrets to non cloud environment.
It ties to address #198