-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for per-cluster and operator global sidecars #331
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
cfcae65
trying to make a more generic sidecar
theRealWardo 940b3c9
fix compilation errors
theRealWardo 20a8348
update for new docs
theRealWardo 232359d
forgot ports
theRealWardo beec6e2
ports not posts silly
theRealWardo 6b2a02b
sidecars not sideCars
theRealWardo 2a32eb4
Merge branch 'master' into global_and_per_cluster_sidecards
alexeyklyukin 1e4f046
Define sidecars in the operator configuration.
alexeyklyukin 0940d36
Refactoring around generatePodTemplate.
alexeyklyukin 57297dc
Deduplicate variables for sidecars.
alexeyklyukin b2ea3b6
Merge branch 'master' into refactoring/sidecars
alexeyklyukin 3a2c570
Document the per-cluster sidecar options
alexeyklyukin fa1259f
Rename the sidecars operator parameter.
alexeyklyukin e4f60e8
Fix a few typos and improve the error messags.
alexeyklyukin 98da75a
Minor refactoring
alexeyklyukin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is preferred == is used ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes