fix netty sequence ability to log subsequent reads and writes #1538
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the bug with the Netty module where it doesn't log subsequent requests. The issue is that the Sequence class that manages sequential processing of reads, then writes has a bug. The method runEagerly() keeps track of a next pointer that tells it which task to run. The problem, also described in the linked issue, is the next pointer is never reset back to the first position in the task array. Applying the suggested changes have fixed the issue. I tested this in a Micronaut app and it is now logging all requests from the server and client reliably. I also wrote a new unit tests showing the Sequence can be reused to process new tasks/requests/responses. Also I wrote the unit test first to ensure it fails without the change.
Motivation and Context
Fixes 1216
Types of changes
Checklist: