Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipper-canary-controller: update cronjob lightstep enviroment variables #8312

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

MustafaSaber
Copy link
Member

use observability token instead of skipper access token and match pod injector as jobs outside kube-system were able to push metrics.

match pod injector as jobs outside `kube-system` push metrics right

Signed-off-by: Mustafa Abdelrahman <[email protected]>
@MustafaSaber MustafaSaber added the minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call. label Oct 7, 2024
@MustafaSaber MustafaSaber self-assigned this Oct 7, 2024
@RomanZavodskikh
Copy link
Contributor

👍

1 similar comment
@MustafaSaber
Copy link
Member Author

👍

@MustafaSaber
Copy link
Member Author

will merge after pipeline finishes

@demonCoder95 demonCoder95 merged commit ccea74c into dev Oct 7, 2024
10 checks passed
@demonCoder95 demonCoder95 deleted the canary-use-config-access-token branch October 7, 2024 16:01
This was referenced Oct 7, 2024
@k8s-on-aws-manager-app k8s-on-aws-manager-app bot mentioned this pull request Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged/alpha merged/beta merged/eks merged/stable minor Minor changes, e.g. low risk config updates, changes that do not introduce a new API call.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants