-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: ingress enable cert tag filter [1/2] #7114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szuecs
changed the title
feature: ingress enable cert tag filter
feature: ingress enable cert tag filter [1/2]
Mar 4, 2024
szuecs
added
the
architectural
New features and architectural changes, e.g. framework changes, migrations, rollout of new services.
label
Mar 4, 2024
Enabled for test as first step. Test certs are all tagged so nothing should happen. It is also enabled for e2e clusters Signed-off-by: Sandor Szücs <[email protected]>
szuecs
force-pushed
the
ingress/cert-enable-tag-filter
branch
from
March 4, 2024 12:33
aab436f
to
3d450e9
Compare
retrigger from here pipeline
|
retrigger from here again next errors is a lot of ingress
|
Found a permission problem for kube-ingress-aws-controller's AWS role |
fix: quotes should not be added to the arg Signed-off-by: Sandor Szücs <[email protected]>
szuecs
force-pushed
the
ingress/cert-enable-tag-filter
branch
from
March 4, 2024 19:01
b47a2b7
to
9f6dd25
Compare
Found wrong quote |
👍 |
1 similar comment
👍 |
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
architectural
New features and architectural changes, e.g. framework changes, migrations, rollout of new services.
merged/alpha
merged/beta
merged/stable
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabled for test as first step. Test certs are all tagged so nothing should happen. It is also enabled for e2e clusters
All new created certs have to have the ACM tag
kubernetes=enabled
to make sure that our ingress controller will pick them up to use in cloud load balancers. It's a safety feature to make sure manually created certificates are not automatically picked up, but there is an active choice to do so.