Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: ingress enable cert tag filter [1/2] #7114

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

szuecs
Copy link
Member

@szuecs szuecs commented Mar 4, 2024

Enabled for test as first step. Test certs are all tagged so nothing should happen. It is also enabled for e2e clusters
All new created certs have to have the ACM tag kubernetes=enabled to make sure that our ingress controller will pick them up to use in cloud load balancers. It's a safety feature to make sure manually created certificates are not automatically picked up, but there is an active choice to do so.

@szuecs szuecs changed the title feature: ingress enable cert tag filter feature: ingress enable cert tag filter [1/2] Mar 4, 2024
@szuecs szuecs added the architectural New features and architectural changes, e.g. framework changes, migrations, rollout of new services. label Mar 4, 2024
Enabled for test as first step. Test certs are all tagged so nothing should happen.
It is also enabled for e2e clusters

Signed-off-by: Sandor Szücs <[email protected]>
@szuecs szuecs force-pushed the ingress/cert-enable-tag-filter branch from aab436f to 3d450e9 Compare March 4, 2024 12:33
@szuecs
Copy link
Member Author

szuecs commented Mar 4, 2024

retrigger from here pipeline e2e-tests, because of this fail (pod readiness issue, so seems not related to the change here):

04/03/2024 13:45:37     Mar  4 13:45:34.204: INFO: Pod "pod-handle-http-request": Phase="Pending", Reason="", readiness=false. Elapsed: 5m0.019409247s

04/03/2024 13:45:37     Mar  4 13:45:34.204: INFO: The phase of Pod pod-handle-http-request is Pending, waiting for it to be Running (with Ready = true)

04/03/2024 13:45:37     Mar  4 13:45:34.205: INFO: Unexpected error: 

04/03/2024 13:45:37         <*pod.timeoutError | 0xc0019d32c0>: {

04/03/2024 13:45:37             msg: "timed out while waiting for pod container-lifecycle-hook-5981/pod-handle-http-request to be running and ready",

04/03/2024 13:45:37             observedObjects: [

04/03/2024 13:45:37                 <*v1.Pod | 0xc00175dc08>{

04/03/2024 13:45:37                     TypeMeta: {Kind: "", APIVersion: ""},

04/03/2024 13:45:37                     ObjectMeta: {

04/03/2024 13:45:37                         Name: "pod-handle-http-request",

04/03/2024 13:45:37                         GenerateName: "",

04/03/2024 13:45:37                         Namespace: "container-lifecycle-hook-5981",

04/03/2024 13:45:37                         SelfLink: "",

04/03/2024 13:45:37                         UID: "0b8a112d-43e1-44a5-9368-2a951416918a",

04/03/2024 13:45:37                         ResourceVersion: "447778",

04/03/2024 13:45:37                         Generation: 0,

04/03/2024 13:45:37                         CreationTimestamp: {

04/03/2024 13:45:37                             Time: {

04/03/2024 13:45:37                                 wall: 0,

04/03/2024 13:45:37                                 ext: 63845156434,

04/03/2024 13:45:37                                 loc: {

04/03/2024 13:45:37                                     name: "Local",

04/03/2024 13:45:37                                     zone: [

04/03/2024 13:45:37                                         {name: "UTC", offset: 0, isDST: false},

04/03/2024 13:45:37                                     ],

04/03/2024 13:45:37                                     tx: [

04/03/2024 13:45:37                                         {

04/03/2024 13:45:37                                             when: -9223372036854775808,

04/03/2024 13:45:37                                             index: 0,

04/03/2024 13:45:37                                             isstd: false,

04/03/2024 13:45:37                                             isutc: false,

04/03/2024 13:45:37                                         },

04/03/2024 13:45:37                                     ],

04/03/2024 13:45:37                                     extend: "UTC0",

04/03/2024 13:45:37                                     cacheStart: -9223372036854775808,

04/03/2024 13:45:37                                     cacheEnd: 9223372036854775807,

04/03/2024 13:45:37                                     cacheZone: {name: "UTC", offset: 0, isDST: false},

04/03/2024 13:45:37                                 },

04/03/2024 13:45:37                             },

04/03/2024 13:45:37                         },

04/03/2024 13:45:37                         DeletionTimestamp: nil,

04/03/2024 13:45:37                         DeletionGracePeriodSeconds: nil,

04/03/2024 13:45:37                         Labels: nil,

04/03/2024 13:45:37                         Annotations: nil,

04/03/2024 13:45:37                         OwnerReferences: nil,

04/03/2024 13:45:37                         Finalizers: nil,

04/03/2024 13:45:37                         ManagedFields: [

04/03/2024 13:45:37                             {

04/03/2024 13:45:37                                 Manager: "e2e.test",

04/03/2024 13:45:37                                 Operation: "Update",

04/03/2024 13:45:37                                 APIVersion: "v1",

04/03/2024 13:45:37                                 Time: {

04/03/2024 13:45:37                                     Time: {

04/03/2024 13:45:37                                         wall: 0,

04/03/2024 13:45:37                                         ext: 63845156434,

04/03/2024 13:45:37                                         loc: {

04/03/2024 13:45:37                                             name: "Local",

04/03/2024 13:45:37                                             zone: [...],

04/03/2024 13:45:37                                             tx: [...],

04/03/2024 13:45:37                                             extend: "UTC0",

04/03/2024 13:45:37                                             cacheStart: -9223372036854775808,

04/03/2024 13:45:37                                             cacheEnd: 9223372036854775807,

04/03/2024 13:45:37                                             cacheZone: {name: ..., offset: ..., isDST: ...},

04/03/2024 13:45:37                                         },

04/03/2024 13:45:37                                     },

04/03/2024 13:45:37                                 },

04/03/2024 13:45:37                                 FieldsType: "FieldsV1",

04/03/2024 13:45:37                                 FieldsV1: {

04/03/2024 13:45:37                                     Raw: "{\"f:spec\":{\"f:affinity\":{\".\":{},\"f:nodeAffinity\":{\".\":{},\"f:requiredDuringSchedulingIgnoredDuringExecution\":{}}},\"f:containers\":{\"k:{\\\"name\\\":\\\"agnhost-container\\\"}\":{\".\":{},\"f:args\":{},\"f:image\":{},\"f:imagePullPolicy\":{},\"f:name\":{},\"f:ports\":{\".\":{},\"k:{\\\"containerPort\\\":8080,\\\"protocol\\\":\\\"TCP\\\"}\":{\".\":{},\"f:containerPort\":{},\"f:protocol\":{}}},\"f:resources\":{},\"f:securityContext\":{},\"f:terminationMessagePath\":{},\"f:terminationMessagePolicy\":{}}},\"f:dnsPolicy\":{},\"f:enableServiceLinks\":{},\"f:restartPolicy\":{},\"f:schedulerName\":{},\"f:securityContext\":{},\"f:terminationGracePeriodSeconds\":{}}}",

04/03/2024 13:45:37                                 },

04/03/2024 13:45:37                                 Subresource: "",

04/03/2024 13:45:37                             },

04/03/2024 13:45:37                             {

04/03/2024 13:45:37                                 Manager: "kube-scheduler",

04/03/2024 13:45:37                                 Operation: "Update",

04/03/2024 13:45:37                 ...

04/03/2024 13:45:37 

04/03/2024 13:45:37     Gomega truncated this representation as it exceeds 'format.MaxLength'.

04/03/2024 13:45:37     Consider having the object provide a custom 'GomegaStringer' representation

04/03/2024 13:45:37     or adjust the parameters in Gomega's 'format' package.

04/03/2024 13:45:37 

04/03/2024 13:45:37     Learn more here: https://onsi.github.io/gomega/#adjusting-output

04/03/2024 13:45:37 

04/03/2024 13:45:37     Mar  4 13:45:34.205: FAIL: timed out while waiting for pod container-lifecycle-hook-5981/pod-handle-http-request to be running and ready

04/03/2024 13:45:37 

04/03/2024 13:45:37     Full Stack Trace

04/03/2024 13:45:37     k8s.io/kubernetes/test/e2e/framework.(*PodClient).CreateSync(0xc000fe5140, 0x38?)

04/03/2024 13:45:37     	/workspace/test/e2e/e2e_modules/kubernetes/test/e2e/framework/pods.go:107 +0x8e

04/03/2024 13:45:37     k8s.io/kubernetes/test/e2e/common/node.init.func12.1.1()

04/03/2024 13:45:37     	/workspace/test/e2e/e2e_modules/kubernetes/test/e2e/common/node/lifecycle_hook.go:65 +0x41a

04/03/2024 13:45:37     github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func2()

04/03/2024 13:45:37     	/go/pkg/mod/github.com/onsi/ginkgo/[email protected]/internal/suite.go:605 +0x82

04/03/2024 13:45:37     created by github.com/onsi/ginkgo/v2/internal.(*Suite).runNode in goroutine 128

04/03/2024 13:45:37     	/go/pkg/mod/github.com/onsi/ginkgo/[email protected]/internal/suite.go:593 +0x619

04/03/2024 13:45:37     [AfterEach] [sig-node] Container Lifecycle Hook

04/03/2024 13:45:37       /workspace/test/e2e/e2e_modules/kubernetes/test/e2e/framework/framework.go:187

04/03/2024 13:45:37     �[1mSTEP:�[0m Collecting events from namespace "container-lifecycle-hook-5981". �[38;5;243m03/04/24 13:45:34.205�[0m

04/03/2024 13:45:37     �[1mSTEP:�[0m Found 4 events. �[38;5;243m03/04/24 13:45:34.212�[0m

@szuecs
Copy link
Member Author

szuecs commented Mar 4, 2024

retrigger from here again

next errors is a lot of ingress

# get pods
skipper-ingress-5cf6d8474b-tcvxk                                        1/1     Running     2 (143m ago)     148m
skipper-ingress-canary-7c4cc7b649-5r87t                                 1/1     Running     2 (143m ago)     148m
skipper-ingress-routesrv-8598f7675c-cczdw                               1/1     Running     0                121m

# logs
[APP]time="2024-03-04T12:55:11Z" level=error msg="error while loading routes from url http://skipper-ingress-routesrv.kube-system.svc.
cluster.local/routes: Get \"http://skipper-ingress-routesrv.kube-system.svc.cluster.local/routes\": dial tcp 10.5.229.160:80: connect:
 connection refused"
[APP]time="2024-03-04T12:55:11Z" level=fatal msg="Get \"http://skipper-ingress-routesrv.kube-system.svc.cluster.local/routes\": dial t
cp 10.5.229.160:80: connect: connection refused"
[TOKENINFO_SANDBOX] 2024/03/04 12:55:11 Configuration loaded successfully, loading JWKS..

## describe pod skipper-ingress 
      Exit Code:    1
      Started:      Mon, 04 Mar 2024 13:55:11 +0100  
      Finished:     Mon, 04 Mar 2024 13:55:11 +0100  
    Ready:          True
    Restart Count:  2
    Limits:

@szuecs
Copy link
Member Author

szuecs commented Mar 4, 2024

Found a permission problem for kube-ingress-aws-controller's AWS role

fix: quotes should not be added to the arg

Signed-off-by: Sandor Szücs <[email protected]>
@szuecs szuecs force-pushed the ingress/cert-enable-tag-filter branch from b47a2b7 to 9f6dd25 Compare March 4, 2024 19:01
@szuecs
Copy link
Member Author

szuecs commented Mar 4, 2024

Found wrong quote

@szuecs
Copy link
Member Author

szuecs commented Mar 5, 2024

👍

1 similar comment
@RomanZavodskikh
Copy link
Contributor

👍

@szuecs szuecs merged commit a949907 into dev Mar 5, 2024
10 checks passed
@szuecs szuecs deleted the ingress/cert-enable-tag-filter branch March 5, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architectural New features and architectural changes, e.g. framework changes, migrations, rollout of new services. merged/alpha merged/beta merged/stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants