Limit nodes considered for ingress load balancer based on taints [1/2] #2749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikkeloscar
force-pushed
the
ingress-controller-targets
branch
2 times, most recently
from
efc7c6a to
cbb744e
Compare
mikkeloscar
changed the title
|
👍 |
|
Depends on full rollout of v1.15 before we can merge because it depends on the |
|
This is now ready for review! |
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
Signed-off-by: Mikkel Oscar Lyderik Larsen <[email protected]>
mikkeloscar
force-pushed
the
ingress-controller-targets
branch
from
aaa291b to
7676cd5
Compare
|
👍 |
1 similar comment
|
👍 |
This was referenced Dec 11, 2019
Closed
Merged
Closed
This was referenced Dec 16, 2019
Closed
Merged
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for how we can reduce the amount of targets in the ingress load balancers to only the relevant nodes.
Right now the problem is that all nodes are considered as target (but only those running skipper will get traffic) even if the node is a master node or a special node pool which wouldn't be able to run skipper because of
taints.The idea is to first only limit the possible targets to worker nodes and then tag all node pools which DON'T have any taints defined to be considered as target. Later we can be more specific and allow certain type of nodes e.g. if we have a dedicated system/skipper node pool in place.
The
tag:zalando.org/ingress-enabled=trueis marked as TODO for now because we need to do the rollout in two steps to be safe.