Make it possible to get a unique ALB for a single ingress resource #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szuecs
reviewed
Feb 23, 2018
README.md
Outdated
| @@ -241,6 +241,11 @@ spec: | |||
|
|
|||
| You can only select from `internet-facing` (default) and `internal` options. | |||
|
|
|||
| By default the ingress-controller will aggregate all ingresses under a single | |||
There was a problem hiding this comment.
single? if you have more than 25 you have 2 :)
There was a problem hiding this comment.
changed it to "as few as possible" :)
szuecs
reviewed
Feb 23, 2018
kubernetes/adapter_test.go
Outdated
| @@ -18,6 +18,7 @@ func TestMappingRoundtrip(t *testing.T) { | |||
| hostName: "bar", | |||
| scheme: "internal", | |||
| certificateARN: "zbr", | |||
| shared: true, | |||
There was a problem hiding this comment.
It would be nice to have also a test case that shows that shared: false works
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an annotation
zalando.org/aws-load-balancer-shared: "false"which, when set will make sure to provision an ALB that is unique for a single ingress resources. This is useful if a single application in the cluster has clients which doesn't support SNI or if it's getting so much traffic that it should not share the ALB with other applications.It works by having a
ingress:owner=<namespace>/<ingress-name>tag on the stacks which are reserved for a single ingress. If the annotation is later removed from the ingress the stacks will be re-aggregated.Fix #129