feat: Update logic for ShardToNodeRatio and MinIndexReplicas #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vkropotko <[email protected]>
|
@s-vkropotko Thanks! Could you add a test covering this change |
Signed-off-by: vkropotko <[email protected]>
|
@mikkeloscar hey! Could you please check tests in the PR? |
otrosien
reviewed
Mar 10, 2021
otrosien
reviewed
Mar 10, 2021
otrosien
reviewed
Mar 10, 2021
otrosien
reviewed
Mar 10, 2021
otrosien
reviewed
Mar 10, 2021
Signed-off-by: vkropotko <[email protected]>
otrosien
reviewed
Mar 12, 2021
Signed-off-by: vkropotko <[email protected]>
otrosien
reviewed
Mar 12, 2021
Signed-off-by: vkropotko <[email protected]>
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
one line summary
Description
With this PR I try to fix a bug with setting minIndexReplicas on config change and update the logic for a ShardToNodeRatio param.
Fix a function calculateNodesWithSameShardToNodeRatio, before if we have shards < nodes, the function conducts division to the number what is <1 (0 < n < 1), as a result function increases replicas.
About an evaluation of number of nodes on checking MinShardsPerNode: looks like it makes sense to do it only in case of the new number of shards is more than MinShardsPerNode.
Types of Changes
Fix bug #141
Minor changes for ShardToNodeRatio param logic
Review
List of tasks the reviewer must do to review the PR
Deployment Notes
These should highlight any db migrations, feature toggles, etc.